Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unit tests coverage of public methods in Design namespace #10773

Open
SimonZhao888 opened this issue Jan 31, 2024 · 4 comments
Open

Missing unit tests coverage of public methods in Design namespace #10773

SimonZhao888 opened this issue Jan 31, 2024 · 4 comments
Assignees
Labels
🚧 work in progress Work that is current in progress help wanted Good issue for external contributors test-enhancement Improvements of test source code
Milestone

Comments

@SimonZhao888
Copy link
Member

SimonZhao888 commented Jan 31, 2024

We are in the process of adding unit tests for all public methods to improve the test coverage of code. Here is a list categorized by namespace.

System.Windows.Forms.Design

@SimonZhao888 SimonZhao888 added the test-enhancement Improvements of test source code label Jan 31, 2024
@ricardobossan
Copy link
Member

ricardobossan commented Jan 31, 2024

There's also this previous list of controls, that were added on #10453 :

image

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Jan 31, 2024

@SimonZhao888 - could you please use this bug only for public classes from System.Windows.Forms.Design namespace - https://github.com/dotnet/winforms/tree/main/src/System.Windows.Forms.Design/src? And then add help-wanted label. We will use this bug to track tests added by contributors.

@Tanya-Solyanik Tanya-Solyanik added this to the Future milestone Jan 31, 2024
@Tanya-Solyanik Tanya-Solyanik changed the title Missing unit tests coverage in Windows Forms runtime Missing unit tests coverage of public methods in Design namespace Jan 31, 2024
@sharwell
Copy link
Member

sharwell commented Jan 31, 2024

Also remember the goal here isn't to increase code coverage. The goal is to identify user/developer scenarios which people are depending on today, and add tests that make it unlikely we would break those users in the future. Every added test should be written from the perspective of what someone using WinForms will try to do, and validate they will get the expected result.

The difference is subtle for public APIs, but for internal APIs that aren't always obvious to invoke, it becomes important to try and write tests targeting those features against public APIs where possible. Tests that exercise behavior using public APIs better reflect user behavior and the tests are much easier to understand if a failure ever shows up.

@SimonZhao888 SimonZhao888 added the help wanted Good issue for external contributors label Feb 1, 2024
@ghost ghost modified the milestones: Future, Help wanted Feb 1, 2024
@ghost
Copy link

ghost commented Feb 1, 2024

This issue is now marked as "help wanted", and we’re looking for a community volunteer to work on this issue. If we receive no interest in 180 days, we will close the issue. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@LeafShi1 LeafShi1 modified the milestones: Help wanted, .NET 9.0 Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label Jul 17, 2024
@Tanya-Solyanik Tanya-Solyanik removed this from the .NET 9.0 milestone Jul 23, 2024
Tanya-Solyanik pushed a commit that referenced this issue Dec 2, 2024
Related #10773

Add unit test DesignerVerbToolStripMenuItemTests.cs for public properties and method of the DesignerVerbToolStripMenuItem.
Tanya-Solyanik pushed a commit that referenced this issue Dec 4, 2024
Related #10773

Proposed changes
Add unit test MaskedTextBoxDesignerActionListTests.cs for public properties and method of the MaskedTextBoxDesignerActionList.
Enable nullability in MaskedTextBoxDesignerActionListTests.cs.
Tanya-Solyanik pushed a commit that referenced this issue Jan 6, 2025
* Add unit tests for ControlDesigner.TransparentBehavior
Related #10773
Tanya-Solyanik pushed a commit that referenced this issue Jan 7, 2025
Related #10773

Proposed changes
Add unit test DataGridViewAddColumnDialogTests.cs for public properties and method of the DataGridViewAddColumnDialog.
Enable nullability in DataGridViewAddColumnDialogTests.cs.
Tanya-Solyanik pushed a commit that referenced this issue Jan 7, 2025
…12664)

Related #10773

Proposed changes
Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject.

Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
Tanya-Solyanik pushed a commit that referenced this issue Jan 8, 2025
Related #10773

Proposed changes
Add unit test LinkAreaEditorTests.cs for public properties and method of the LinkAreaEditor.
Enable nullability in LinkAreaEditorTests.cs.
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
* Add unit tests for ControlDesigner.TransparentBehavior
Related dotnet#10773
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
Related dotnet#10773

Proposed changes
Add unit test DataGridViewAddColumnDialogTests.cs for public properties and method of the DataGridViewAddColumnDialog.
Enable nullability in DataGridViewAddColumnDialogTests.cs.
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
…otnet#12664)

Related dotnet#10773

Proposed changes
Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject.

Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
Related dotnet#10773

Proposed changes
Add unit test LinkAreaEditorTests.cs for public properties and method of the LinkAreaEditor.
Enable nullability in LinkAreaEditorTests.cs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 work in progress Work that is current in progress help wanted Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

6 participants