Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ControlDesigner.ControlDesignerAccessibleObject #12664

Conversation

MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Dec 20, 2024

Related #10773

Proposed changes

  • Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject.

  • Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12135%. Comparing base (8d96e56) to head (2962e97).
Report is 35 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12664         +/-   ##
===================================================
+ Coverage   76.02394%   76.12135%   +0.09741%     
===================================================
  Files           3180        3186          +6     
  Lines         639659      639965        +306     
  Branches       47216       47227         +11     
===================================================
+ Hits          486294      487150        +856     
+ Misses        149851      149297        -554     
- Partials        3514        3518          +4     
Flag Coverage Δ
Debug 76.12135% <100.00000%> (+0.09741%) ⬆️
integration 18.17064% <ø> (+0.01479%) ⬆️
production 50.00545% <ø> (+0.19542%) ⬆️
test 97.02599% <100.00000%> (+0.00086%) ⬆️
unit 47.22778% <ø> (+0.18839%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dotnet-policy-service dotnet-policy-service bot added the 📭 waiting-author-feedback The team requires more information from the author label Dec 20, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 23, 2024
ricardobossan
ricardobossan previously approved these changes Dec 23, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added some minor comments only.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Jan 7, 2025
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Jan 7, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@Tanya-Solyanik Tanya-Solyanik merged commit ba481ce into dotnet:main Jan 7, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 7, 2025
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_ControlDesigner.ControlDesignerAccessibleObject branch January 8, 2025 01:07
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
…otnet#12664)

Related dotnet#10773

Proposed changes
Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject.

Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants