-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for ControlDesigner.ControlDesignerAccessibleObject #12664
Add unit tests for ControlDesigner.ControlDesignerAccessibleObject #12664
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12664 +/- ##
===================================================
+ Coverage 76.02394% 76.12135% +0.09741%
===================================================
Files 3180 3186 +6
Lines 639659 639965 +306
Branches 47216 47227 +11
===================================================
+ Hits 486294 487150 +856
+ Misses 149851 149297 -554
- Partials 3514 3518 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I added some minor comments only.
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...nitTests/System/Windows/Forms/Design/ControlDesigner.ControlDesignerAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good!
…otnet#12664) Related dotnet#10773 Proposed changes Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject. Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
Related #10773
Proposed changes
Add unit test ControlDesigner.ControlDesignerAccessibleObjectTests.cs for public properties and method of the ControlDesigner.ControlDesignerAccessibleObject.
Enable nullability in ControlDesigner.ControlDesignerAccessibleObjectTests.cs.
Microsoft Reviewers: Open in CodeFlow