Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace for ImageIndexEditorTests #12452

Merged

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented Nov 8, 2024

Fixes #12237
Related #10773

Proposed changes

  • Fixes namespace for the ImageIndexEditorTests class.

Customer Impact

  • None

Risk

  • Minimal

Test environment(s)

  • 9.0.100-rc.2.24474.12
Microsoft Reviewers: Open in CodeFlow

@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Nov 8, 2024
@ricardobossan ricardobossan self-assigned this Nov 8, 2024
@ricardobossan ricardobossan requested a review from a team as a code owner November 8, 2024 21:24
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.69138%. Comparing base (40f4e93) to head (671d85a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12452         +/-   ##
===================================================
- Coverage   75.69249%   75.69138%   -0.00112%     
===================================================
  Files           3151        3151                 
  Lines         635717      635717                 
  Branches       46987       46987                 
===================================================
- Hits          481190      481183          -7     
- Misses        151088      151089          +1     
- Partials        3439        3445          +6     
Flag Coverage Δ
Debug 75.69138% <ø> (-0.00112%) ⬇️
integration 18.26166% <ø> (-0.00072%) ⬇️
production 49.24151% <ø> (-0.00141%) ⬇️
test 97.04689% <ø> (-0.00085%) ⬇️
unit 46.22763% <ø> (+0.00562%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! 😄

@lonitra lonitra merged commit 4226733 into dotnet:main Nov 8, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 8, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Nov 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants