-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write unit test for DataGridViewAddColumnDialog #12662
Write unit test for DataGridViewAddColumnDialog #12662
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12662 +/- ##
===================================================
+ Coverage 75.91962% 76.07613% +0.15651%
===================================================
Files 3164 3165 +1
Lines 636813 639374 +2561
Branches 47008 47186 +178
===================================================
+ Hits 483466 486411 +2945
+ Misses 149884 149448 -436
- Partials 3463 3515 +52
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than small comments, all LGTM!
...Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewAddColumnDialogTests.cs
Outdated
Show resolved
Hide resolved
...Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewAddColumnDialogTests.cs
Outdated
Show resolved
Hide resolved
...Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewAddColumnDialogTests.cs
Outdated
Show resolved
Hide resolved
...Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewAddColumnDialogTests.cs
Outdated
Show resolved
Hide resolved
...Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DataGridViewAddColumnDialogTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good!
Related dotnet#10773 Proposed changes Add unit test DataGridViewAddColumnDialogTests.cs for public properties and method of the DataGridViewAddColumnDialog. Enable nullability in DataGridViewAddColumnDialogTests.cs.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow