Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for ImageListImage #11736

Merged

Conversation

John-Qiao
Copy link
Member

@John-Qiao John-Qiao commented Jul 23, 2024

Related #10773

Proposed changes

  • Add unit test ImageListImageTests.cs for public properties and method of the ImageListImage.
  • Enable nullability in ImageListImage.
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner July 23, 2024 10:24
@John-Qiao John-Qiao added the waiting-review This item is waiting on review by one or more members of team label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74036%. Comparing base (fa07c1b) to head (b0a8e66).
Report is 46 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11736         +/-   ##
======================================================
+ Coverage      74.55969%   74.74036%   +0.18066%     
======================================================
  Files              3041        3046          +5     
  Lines            629780      630690        +910     
  Branches          46845       46862         +17     
======================================================
+ Hits             469562      471380       +1818     
+ Misses           156849      155952        -897     
+ Partials           3369        3358         -11     
Flag Coverage Δ
Debug 74.74036% <100.00000%> (+0.18066%) ⬆️
integration 17.96114% <ø> (+0.08839%) ⬆️
production 47.76249% <ø> (+0.31575%) ⬆️
test 96.98579% <100.00000%> (+0.00753%) ⬆️
unit 44.80418% <ø> (+0.23172%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Jul 23, 2024
@lonitra lonitra merged commit f7f23d3 into dotnet:feature/10.0 Jul 23, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants