Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ListControlStringCollectionEditor #12516

Conversation

Nora-Zhou01
Copy link
Member

@Nora-Zhou01 Nora-Zhou01 commented Nov 20, 2024

Related #10773

Proposed changes

  • Add unit test ListControlStringCollectionEditorTests.cs for public properties and method of the ListControlStringCollectionEditor
  • Enable nullability in ListControlStringCollectionEditorTests.cs
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75246%. Comparing base (e4085eb) to head (b59e579).
Report is 365 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12516         +/-   ##
===================================================
+ Coverage   75.01536%   75.75246%   +0.73709%     
===================================================
  Files           3047        3160        +113     
  Lines         631584      635978       +4394     
  Branches       46764       46987        +223     
===================================================
+ Hits          473785      481769       +7984     
+ Misses        154434      150747       -3687     
- Partials        3365        3462         +97     
Flag Coverage Δ
Debug 75.75246% <100.00000%> (+0.73709%) ⬆️
integration 18.17832% <ø> (+0.24391%) ⬆️
production 49.30874% <ø> (+1.18410%) ⬆️
test 97.04622% <100.00000%> (+0.02975%) ⬆️
unit 46.52536% <ø> (+1.39921%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Nora-Zhou01 Nora-Zhou01 added the waiting-review This item is waiting on review by one or more members of team label Nov 22, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Nov 22, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM. Just make sure to rebase with updated main remote upstream branch, to get rid of the errors when trying to build.

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 25, 2024
@lonitra lonitra merged commit 8a962d5 into dotnet:main Nov 25, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants