Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ControlDesigner.TransparentBehavior #12694

Conversation

MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Dec 30, 2024

Related #10773

Proposed changes

  • Add unit test ControlDesigner.TransparentBehaviorTests.cs for public properties and method of the ControlDesigner.TransparentBehavior.
  • Enable nullability in ControlDesigner.TransparentBehaviorTests.cs.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.04530%. Comparing base (0ce1218) to head (62ae49b).
Report is 8 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12694         +/-   ##
===================================================
+ Coverage   76.03858%   76.04530%   +0.00672%     
===================================================
  Files           3181        3182          +1     
  Lines         639670      639720         +50     
  Branches       47215       47216          +1     
===================================================
+ Hits          486396      486477         +81     
+ Misses        149756      149728         -28     
+ Partials        3518        3515          -3     
Flag Coverage Δ
Debug 76.04530% <90.00000%> (+0.00672%) ⬆️
integration 18.16254% <ø> (-0.00986%) ⬇️
production 49.84623% <ø> (+0.01265%) ⬆️
test 97.03098% <90.00000%> (-0.00100%) ⬇️
unit 47.04396% <ø> (-0.01054%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small a comment, LGTM!

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 31, 2024
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good!

@Tanya-Solyanik Tanya-Solyanik merged commit 8841a1e into dotnet:main Jan 6, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 6, 2025
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_ControlDesigner.TransparentBehavior branch January 7, 2025 01:11
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
* Add unit tests for ControlDesigner.TransparentBehavior
Related dotnet#10773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants