Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DesignerVerbToolStripMenuItem #12566

Conversation

MelonWang1
Copy link
Contributor

@MelonWang1 MelonWang1 commented Nov 29, 2024

Related #10773

Proposed changes

  • Add unit test DesignerVerbToolStripMenuItemTests.cs for public properties and method of the DesignerVerbToolStripMenuItem.
  • Enable nullability in DesignerVerbToolStripMenuItem.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.80128%. Comparing base (b91747d) to head (2bf791f).
Report is 10 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12566         +/-   ##
===================================================
+ Coverage   75.77766%   75.80128%   +0.02362%     
===================================================
  Files           3161        3163          +2     
  Lines         636074      636389        +315     
  Branches       46989       46997          +8     
===================================================
+ Hits          482002      482391        +389     
+ Misses        150614      150530         -84     
- Partials        3458        3468         +10     
Flag Coverage Δ
Debug 75.80128% <100.00000%> (+0.02362%) ⬆️
integration 18.07202% <ø> (-0.12076%) ⬇️
production 49.38349% <ø> (+0.02680%) ⬆️
test 97.05071% <100.00000%> (+0.00260%) ⬆️
unit 46.65590% <ø> (+0.11954%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label Nov 29, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label Dec 2, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 2b17fa7 into dotnet:main Dec 2, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Dec 2, 2024
@MelonWang1 MelonWang1 deleted the Add_unit_tests_for_DesignerVerbToolStripMenuItem branch December 3, 2024 01:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants