Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for UpDownBaseDesigner #12364

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

Liv-Goh
Copy link
Contributor

@Liv-Goh Liv-Goh commented Oct 22, 2024

Related #10773

Proposed changes

  1. Add unit test UpDownBaseDesignerTests.cs for public properties and method of the UpDownBaseDesigner.
  2. Enable nullability in UpDownBaseDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@Liv-Goh Liv-Goh requested a review from a team as a code owner October 22, 2024 03:09
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03074%. Comparing base (572677b) to head (a47b22a).
Report is 32 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12364          +/-   ##
====================================================
+ Coverage   75.60672%   97.03074%   +21.42402%     
====================================================
  Files           3115        1156        -1959     
  Lines         635138      351637      -283501     
  Branches       46921        5283       -41638     
====================================================
- Hits          480207      341196      -139011     
+ Misses        151479        9691      -141788     
+ Partials        3452         750        -2702     
Flag Coverage Δ
Debug 97.03074% <100.00000%> (+21.42401%) ⬆️
integration ?
production ?
test 97.03074% <100.00000%> (+0.00542%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Oct 22, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 23, 2024
@ricardobossan ricardobossan added the 📭 waiting-author-feedback The team requires more information from the author label Oct 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 23, 2024
@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Oct 23, 2024
ricardobossan
ricardobossan previously approved these changes Oct 23, 2024
@ricardobossan ricardobossan removed the waiting-review This item is waiting on review by one or more members of team label Oct 23, 2024
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Oct 23, 2024
@ricardobossan ricardobossan dismissed their stale review October 23, 2024 16:40

New reviews came up

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Oct 25, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lookd good

@lonitra lonitra merged commit 8c0a6d0 into dotnet:main Oct 25, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants