Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for MaskedTextBoxDesignerActionList #12491

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Nov 15, 2024

Related #10773

Proposed changes

  1. Add unit test MaskedTextBoxDesignerActionListTests.cs for public properties and method of the MaskedTextBoxDesignerActionList.
  2. Enable nullability in MaskedTextBoxDesignerActionListTests.cs.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83272%. Comparing base (65f897b) to head (c41aa78).
Report is 92 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12491         +/-   ##
===================================================
+ Coverage   75.65407%   75.83272%   +0.17864%     
===================================================
  Files           3150        3165         +15     
  Lines         635831      636472        +641     
  Branches       47020       47002         -18     
===================================================
+ Hits          481032      482654       +1622     
+ Misses        151352      150349       -1003     
- Partials        3447        3469         +22     
Flag Coverage Δ
Debug 75.83272% <100.00000%> (+0.17864%) ⬆️
integration 18.16396% <ø> (-0.08512%) ⬇️
production 49.45068% <ø> (+0.25235%) ⬆️
test 97.05123% <100.00000%> (+0.02100%) ⬆️
unit 46.67078% <ø> (+0.51482%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Syareel-Sukeri Syareel-Sukeri added the waiting-review This item is waiting on review by one or more members of team label Nov 18, 2024
@ricardobossan ricardobossan added the 📭 waiting-author-feedback The team requires more information from the author label Nov 20, 2024
@LeafShi1 LeafShi1 removed the waiting-review This item is waiting on review by one or more members of team label Nov 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 22, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing scenario could be tested as part of the MaskDesignerDialog testing, it's ok to remove it from this file.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Dec 3, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 4, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit e2ee696 into dotnet:main Dec 4, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Dec 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants