Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for MaskDesignerDialog #12575

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Add unit test for MaskDesignerDialog #12575

merged 4 commits into from
Dec 5, 2024

Conversation

Liv-Goh
Copy link
Contributor

@Liv-Goh Liv-Goh commented Dec 3, 2024 •
edited by dotnet-policy-service bot
Loading

Related #10773

Proposed changes

  1. Add unit test MaskDesignerDialogTests.cs for public properties and method of the MaskDesignerDialog.
  2. Enable nullability in MaskDesignerDialogTests..cs.
Microsoft Reviewers: Open in CodeFlow

@Liv-Goh Liv-Goh requested a review from a team as a code owner December 3, 2024 08:25
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.88930%. Comparing base (e91e3bc) to head (955c5d7).
Report is 34 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #12575         +/-   ##
===================================================
+ Coverage   75.75455%   75.88930%   +0.13475%     
===================================================
  Files           3159        3166          +7     
  Lines         635942      636684        +742     
  Branches       46987       47010         +23     
===================================================
+ Hits          481755      483175       +1420     
+ Misses        150726      150044        -682     
- Partials        3461        3465          +4
Flag Coverage Δ
Debug 75.88930% <86.66667%> (+0.13475%) ⬆️
integration 18.17067% <ø> (-0.00411%) ⬇️
production 49.56241% <ø> (+0.24486%) ⬆️
test 97.05073% <86.66667%> (+0.00566%) ⬆️
unit 46.78216% <ø> (+0.25045%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Dec 3, 2024
ricardobossan
ricardobossan reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small comments, LGTM!

....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/MaskDesignerDialogTests.cs Outdated Show resolved Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/MaskDesignerDialogTests.cs Show resolved Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/MaskDesignerDialogTests.cs Outdated Show resolved Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/MaskDesignerDialogTests.cs Outdated Show resolved Hide resolved
@ricardobossan ricardobossan added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Dec 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 4, 2024
lonitra
lonitra reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about using target type new otherwise 👍

....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/MaskDesignerDialogTests.cs Outdated Show resolved Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/MaskDesignerDialogTests.cs Outdated Show resolved Hide resolved
....Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/MaskDesignerDialogTests.cs Outdated Show resolved Hide resolved
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Dec 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Dec 5, 2024
lonitra
lonitra approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit 6ecb29a into dotnet:main Dec 5, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ricardobossan ricardobossan ricardobossan approved these changes

@lonitra lonitra lonitra approved these changes

Assignees

@Liv-Goh Liv-Goh

Labels
None yet
Projects
None yet
Milestone
10.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@Liv-Goh @lonitra @ricardobossan