Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for DataSourceGroupCollection #12430

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Nov 6, 2024

Related #10773

Proposed changes

  • Add unit test DataSourceGroupCollectionTests.cs for public methods of the DataSourceGroupCollection.
  • Enable nullability in DataSourceGroupCollectionTests.cs.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.04774%. Comparing base (23c5c5e) to head (e5a6771).
Report is 19 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12430          +/-   ##
====================================================
+ Coverage   75.63616%   97.04774%   +21.41158%     
====================================================
  Files           3147        1161        -1986     
  Lines         635807      351731      -284076     
  Branches       47013        5277       -41736     
====================================================
- Hits          480900      341347      -139553     
+ Misses        151457        9635      -141822     
+ Partials        3450         749        -2701     
Flag Coverage Δ
Debug 97.04774% <94.82759%> (+21.41158%) ⬆️
integration ?
production ?
test 97.04774% <94.82759%> (+0.01689%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments otherwise looks good 👍

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Nov 7, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 8, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit 40f4e93 into dotnet:main Nov 8, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 8, 2024
@Olina-Zhang Olina-Zhang deleted the UnitTest_DataSourceGroupCollection branch November 15, 2024 02:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants