Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Kiota #2509
base: main
Are you sure you want to change the base?
Adding support for Kiota #2509
Changes from all commits
44ca5be
d0cbc94
af8f321
ad02256
4c22b24
bc4611c
8c42f30
f3ca270
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about this. I see there is no separate UnoFeature for
Refit
, it just comes as part of theHttp
feature. I know @francoistanguay mentioned we may replace Refit with Kiota rather than having both. We could instead split this asHttpRefit
andHttpKiota
feature?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along with that, @jeromelaban we would need to make some changes to the uno.sdk to include the Uno.Extensions.Kiota packages as part of the Http UnoFeature in order for this to work as is, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends. If this package is transitively included, there's no need. If it's optional, then yes, we'll need to.