Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for Kiota #2509

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adding support for Kiota #2509

wants to merge 8 commits into from

Conversation

Kunal22shah
Copy link
Contributor

@Kunal22shah Kunal22shah commented Aug 12, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #2510

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah requested a review from kazo0 August 12, 2024 20:52
@Kunal22shah Kunal22shah self-assigned this Aug 12, 2024
@kazo0 kazo0 mentioned this pull request Aug 14, 2024
Open
@Kunal22shah Kunal22shah force-pushed the dev/ks/add-kiota-extension branch from 1e8ff64 to 44ca5be Compare August 20, 2024 14:12
@Kunal22shah Kunal22shah marked this pull request as ready for review August 20, 2024 14:14
kazo0
kazo0 reviewed Dec 16, 2024
View reviewed changes
doc/Learn/Http/HowTo-Kiota.md Outdated Show resolved Hide resolved
doc/Learn/Http/HowTo-Kiota.md Outdated Show resolved Hide resolved
@Kunal22shah Kunal22shah requested a review from kazo0 December 17, 2024 20:21
kazo0
kazo0 reviewed Dec 17, 2024
View reviewed changes
doc/Learn/Http/HowTo-Kiota.md
<UnoFeatures>
Material;
Extensions;
+ Http;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about this. I see there is no separate UnoFeature for Refit, it just comes as part of the Http feature. I know @francoistanguay mentioned we may replace Refit with Kiota rather than having both. We could instead split this as HttpRefit and HttpKiota feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with that, @jeromelaban we would need to make some changes to the uno.sdk to include the Uno.Extensions.Kiota packages as part of the Http UnoFeature in order for this to work as is, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends. If this package is transitively included, there's no need. If it's optional, then yes, we'll need to.

@unodevops
Copy link

⚠️⚠️ The build 150533 has failed on uno.extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@kazo0 kazo0 kazo0 left review comments

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

At least 1 approving review is required to merge this pull request.

Assignees

@Kunal22shah Kunal22shah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Http] Add support for Kiota
5 participants
@Kunal22shah @unodevops @nickrandolph @kazo0 @jeromelaban