refactor(core): Use DTOs for source control push/pull requests #12470
+320
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend requires it, and it's always passed.
n8n-assistant
bot
added
core
netroy
force-pushed
the
source-control-DTO-refactor
branch
from
25f7b01 to
f7cfc97
Compare
4 tasks
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
despairblue
changed the title
despairblue
reviewed
Jan 6, 2025
packages/cli/src/environments.ee/source-control/source-control.controller.ee.ts
Show resolved
Hide resolved
Comment on lines
+26
to
+59
| { | ||
| name: 'push request with only required fields', | ||
| request: { | ||
| fileNames: [ | ||
| { | ||
| file: 'file2.json', | ||
| id: '2', | ||
| name: 'File 2', | ||
| type: 'credential', | ||
| status: 'new', | ||
| location: 'remote', | ||
| conflict: true, | ||
| updatedAt: '2023-10-02T12:00:00Z', | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| { | ||
| name: 'push request with optional fields omitted', | ||
| request: { | ||
| fileNames: [ | ||
| { | ||
| file: 'file3.json', | ||
| id: '3', | ||
| name: 'File 3', | ||
| type: 'variables', | ||
| status: 'deleted', | ||
| location: 'local', | ||
| conflict: false, | ||
| updatedAt: '2023-10-03T12:00:00Z', | ||
| }, | ||
| ], | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Only required fields is the same as optional fields omitted, isn't it?
There was a problem hiding this comment.
I'm using LLMs to generate these tests, and once tests pass and all lines are covered, I just commit.
but considering the last few reviews, looks like even the top of the line LLMs are creating too much slop. I'll have a look at these tests again 🙏🏽.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This continues the DTO refactor work.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)