Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean few source control cases #11150

Closed
wants to merge 3 commits into from

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Oct 8, 2024

Summary

  • Remove unused parameter
  • Make parameter required: Backend requires it, and it's always passed.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 8, 2024
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the frontend call, SourceControlPullWorkFolder should only have a force: boolean. No other field seem used.

while we are at it, we should also trim down SourceControlPushWorkFolder.

@netroy
Copy link
Member

netroy commented Jan 6, 2025

cherry-picked these commits, and removed more unused properties in #12470

@netroy netroy closed this Jan 6, 2025
@netroy netroy deleted the refactor-clean-few-source-control-cases branch January 6, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants