Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed command for listing domains required for Codespaces #35800

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fixed command for listing domains required for Codespaces #35800

merged 2 commits into from
Jan 6, 2025

Conversation

StefanFB
Copy link
Contributor

@StefanFB StefanFB commented Dec 31, 2024 •
edited by felicitymay
Loading

Why:

The 'gh api meta | jq .domains.codespaces' did not work for me in the Windows Command Prompt. It gives an error: "'jq' is not recognized as an internal or external command, operable program or batch file."

Changing the command to 'gh api meta --jq .domains.codespaces' gives the desired output. This is also consistent with the manual after 'gh api meta -help'.

Closes: #35799

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changed:
gh api meta | jq .domains.codespaces
To:
gh api meta --jq .domains.codespaces

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

@StefanFB
Fixed command for listing domains required for Codespaces
fe026af 
The 'gh api meta | jq .domains.codespaces' did not work for me in Command Prompt. It gives an error: 
"'jq' is not recognized as an internal or external command,
operable program or batch file."

Changing the command to 'gh api meta --jq .domains.codespaces' gives the desired output. This is also consistent with the manual after 'gh api meta -help'.
@welcome Welcome
Copy link

welcome bot commented Dec 31, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 31, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/troubleshooting/troubleshooting-your-connection-to-github-codespaces.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Dec 31, 2024
@nguyenalex836
Copy link
Contributor

@StefanFB Thanks so much for opening a PR! I'll get this triaged for review ✨

felicitymay
felicitymay approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the update and it works on Mac as well as Windows 👍🏻

@felicitymay
Copy link
Contributor

Many thanks for opening the issue and this PR to fix this error, it's much appreciated.

I'll label this change for merging.

@felicitymay felicitymay added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 2, 2025
@StefanFB
Copy link
Contributor Author

StefanFB commented Jan 4, 2025

@felicitymay Thank you for looking into it and getting it ready to publish!

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into github:main with commit 6c20e88 Jan 6, 2025
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@nguyenalex836 nguyenalex836 mentioned this pull request Jan 6, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicitymay felicitymay felicitymay approved these changes

Assignees
No one assigned
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong command in Codespaces troubleshooting page
3 participants
@StefanFB @nguyenalex836 @felicitymay