Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong command in Codespaces troubleshooting page #35799

Closed
1 task done
Tracked by #35801
StefanFB opened this issue Dec 31, 2024 · 6 comments · Fixed by #35800
Closed
1 task done
Tracked by #35801

Wrong command in Codespaces troubleshooting page #35799

StefanFB opened this issue Dec 31, 2024 · 6 comments · Fixed by #35800
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team

Comments

@StefanFB
Copy link
Contributor

StefanFB commented Dec 31, 2024

Code of Conduct

What article on docs.github.com is affected?

Troubleshooting your connection to GitHub Codespaces - Oh no, it looks like you are offline has a command that does not seem to be working.

What part(s) of the article would you like to see updated?

Specifically this part:

To get the list of domains required by GitHub Codespaces, execute the following command using GitHub CLI:

gh api meta | jq .domains.codespaces

Additional information

This is my output upon entering the command.
I am using Windows 10 and the command prompt terminal.

<me_on_Windows>gh api meta | jq .domains.codespaces
'jq' is not recognized as an internal or external command,
operable program or batch file.

This is fixed when changing the command to:

<me_on_windows>gh api meta --jq .domains.codespaces
[
  "*.github.com",
  "*.api.github.com",
  "*.azureedge.net",
  "*.github.dev",
  "*.msecnd.net",
  "*.visualstudio.com",
  "*.vscode-webview.net",
  "*.windows.net",
  "*.microsoft.com"
]
@StefanFB StefanFB added the content This issue or pull request belongs to the Docs Content team label Dec 31, 2024
Copy link

welcome bot commented Dec 31, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 31, 2024
@nguyenalex836 nguyenalex836 added Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Dec 31, 2024
@nguyenalex836
Copy link
Contributor

@StefanFB Thank you for opening an issue and linking it to your PR! ✨

@felicitymay
Copy link
Contributor

@StefanFB - many thanks for opening this issue with a clear definition of the problem and the environment that you're using. It's really helpful.

When I run the two commands in a terminal on my mac, both commands work. I expect that Windows maybe the outlier here. However, I agree that we should update this command to work on all operating systems and to match the reference article.

@StefanFB
Copy link
Contributor Author

StefanFB commented Jan 4, 2025

@nguyenalex836 @felicitymay Thank you for the kind reaction and I am happy I was able to give a little help.

@COOLCY16
Copy link

COOLCY16 commented Jan 5, 2025

We hope to GitHub fixes this soon

@nguyenalex836
Copy link
Contributor

The linked PR has been merged 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants