Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default agent title if input blank text for form of agent title #289

Conversation

kentaro-m
Copy link
Contributor

Summary

Set default agent title if input blank text for form of agent title

2025-01-06.22.08.47.mov

Related Issue

#266

Changes

Testing

Other Information

Copy link

vercel bot commented Jan 6, 2025

@kentaro-m is attempting to deploy a commit to the Edge Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 1:36pm

@kentaro-m kentaro-m self-assigned this Jan 6, 2025
@kentaro-m kentaro-m linked an issue Jan 6, 2025 that may be closed by this pull request
2 tasks
@kentaro-m kentaro-m marked this pull request as ready for review January 6, 2025 13:39
Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


JFYI:
I have created a new issue for inconsistencies in terminology across the entire product.

#291

Copy link
Contributor

@toyamarinyon toyamarinyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, It works but update database agent name to "Untitled Agent".

I want to update null in this case.

Sample implementations: #292

@kentaro-m
Copy link
Contributor Author

kentaro-m commented Jan 7, 2025

@toyamarinyon
Thank you for your comment.

I've checked PR #292.

It seems that the change made was to set a fallback value in the Agent Name form when the agentName is updated with a null value.

The goal of this PR was to avoid to show blank text for form, so it seems that PR #292 has achieved its intended purpose for #262.

May I close my PR?

@kentaro-m kentaro-m requested a review from toyamarinyon January 8, 2025 15:53
@shige
Copy link
Member

shige commented Jan 9, 2025

I'm going ahead and closing this PR. Thanks so much for your contribution!

@shige shige closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent title can be left blank during creation
3 participants