Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent title can be left blank during creation #266

Open
2 tasks done
shige opened this issue Dec 23, 2024 · 3 comments · May be fixed by #292
Open
2 tasks done

Agent title can be left blank during creation #266

shige opened this issue Dec 23, 2024 · 3 comments · May be fixed by #292
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@shige
Copy link
Member

shige commented Dec 23, 2024

Self Checks

Cloud or Self Hosted

Cloud

Version (only for Self Hosted)

No response

Steps to reproduce

  1. Open the Agent Playground page.
  2. Change the Agent title to 0 characters from the left menu.

image

Expected Behavior

Option 1)
If the Agent title is left blank, a validation error should occur, preventing configuration.

Option 2)
Make the Agent title text box more noticeable (e.g., by changing the border color of the text box).

Actual Behavior

It is currently possible to configure an Agent without setting a title.

Additional Context

If allowing an unset title is intentional, the text box for setting the title is not visible, as shown in the attached image. Therefore, I am submitting this report suggesting that it would be better to address the issue in one of the following ways:

@shige shige added bug Something isn't working help wanted Extra attention is needed labels Dec 23, 2024
@kentaro-m kentaro-m self-assigned this Jan 6, 2025
@kentaro-m
Copy link
Contributor

I'll do it.

@kentaro-m
Copy link
Contributor

@shige
I would like to propose a new option. How about the following solution?

If a user inputs blank text to agent title, set default agent name.
I suggest this one because it costs less to resolve than the other options.

2025-01-06.22.08.47.mov

If it is OK, I will send you a PR.

@shige
Copy link
Member Author

shige commented Jan 6, 2025

@kentaro-m Certainly, I think that proposal is sufficient! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
3 participants