Don't override provided source code #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavrilikhin-d
commented
Oct 5, 2023
|
|
||
| use crate::{Diagnostic, LabeledSpan, Report, SourceCode, SourceSpan}; | ||
|
|
||
| #[derive(Error, Debug)] |
There was a problem hiding this comment.
I couldn't use derive macro here. Looks like it always expands to miette::, instead of crate::. This may be fixed with $crate:: in macro implementation, I think
gavrilikhin-d
commented
Oct 5, 2023
Comment on lines
+282
to
+292
| let underlined = String::from_utf8( | ||
| report | ||
| .source_code() | ||
| .unwrap() | ||
| .read_span(&(0..5).into(), 0, 0) | ||
| .unwrap() | ||
| .data() | ||
| .to_vec(), | ||
| ) | ||
| .unwrap(); | ||
| assert_eq!(underlined, "hello"); |
There was a problem hiding this comment.
Maybe there is a better way to check that sources are equal?
gavrilikhin-d
commented
Oct 5, 2023
| }) | ||
| .with_source_code(outer_source.to_string()); | ||
|
|
||
| let message = format!("{:?}", report); |
There was a problem hiding this comment.
Debug printing without fancy feature is broken
zkat
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299