Add recursive_fold and recursive_2 to prevent memory leaks #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
recursive_2
orrecursive_fold
instead ofRecursive::declare
we can prevent situations where we either keep too many strong references around, leading to memory leaks, or too few strong references around, leading to broken parsers because all the strong references and the parsers are dropped.We could consider removing
Recursive::declare
from the public API, since it is hard to use it correctly.Please see the investigation (for version 0.9) in #486 (comment)
If code is migrated to use
recursive_2
orrecursive_fold
we should be able to resolve #486 I have tested that this patch for 0.9 fixes the memory issue on jaq when repeatedly creating parsers.