[WIP] [zero-copy] Static analysis

[CraftSpider]

This is all slightly cursed, and horribly WIP, but I wanted it up for viewing

[zesterer]

This is neat! I like the trait-based API. I feel like this is worth putting behind a feature flag though.

[CraftSpider]

Yeah, probably. I'll add the feature flag, and try to flesh out more of the parsers with implementations. I'm still not super happy with how much state the visitor has to carry around, but I'm not sure how to do it much better while still being generic over any possible parser.

[m-hugo]

Why is zesterer:zero-copy still targeted instead of zesterer:main ? it makes the diff unreadable

[CraftSpider]

By mistake - fixed the target

[zesterer]

Is this ready for review?

[CraftSpider]

I'm iffy on this one still - I'm not super happy with the API, but if you want to get it in and not expose it till later, I think it's at least ready for that.

[m-hugo]

why not expose this and pratt in an experimental (use chumsky::experimental::{problems, pratt}) module ?
that way it's not in indefinite limbo and you can rework it later

[zesterer]

Adding this later wouldn't be a breaking change, so I don't think there's any particular pressure to push this (or the pratt parser) right now. If @CraftSpider feels like it's ready, then great: but I think I'd generally err on the side of waiting a little bit or releasing it in a future alpha (1.1, perhaps) to get a feel for what the API should be able to do.

[CraftSpider]

Once I have the motivation and time, I'll prioritise improving the API here, to be clear. It's just in limbo right now because I've both been busy and struggling to draw up the motivation to work on it.

[zesterer]

Once I have the motivation and time, I'll prioritise improving the API here, to be clear. It's just in limbo right now because I've both been busy and struggling to draw up the motivation to work on it.

That's ok! I find my motivation comes and goes a lot too. It definitely shows in my commit history :D