Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vant-compat): [Field] Fix the false positive empty value when the value is boolean false #12956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(vant-compat): [Field] Fix the false positive empty value when the value is boolean false #12956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vant/src/field/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function isEmptyValue(value: unknown) {
if (Array.isArray(value)) {
return !value.length;
}
if (value === 0) {
if (value === 0 || typeof value === 'boolean') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the Checkbox component

Copy link
Author

@YujiaCheng1996 YujiaCheng1996 Jun 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a single boolean Radio/Checkbox/Switch is required, users have to select true, which is not ideal.
单选/多选/开关如果单独绑定布尔值并设置必填，用户必须选择是，若选否/关闭开关，校验不通过，不是很理想。
Users should be able to choose false, or turn off the switch. In this case, just check the value is undefined/null/NaN or not will be enough.
用户应该能选否或关闭开关，这样只要检查值不为空就行。
Maybe there is a more elegant apporach.
可能有其他更好的解决方法。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯，修复这个问题的前提是不破坏现有的正确逻辑，比如 Checkbox 组件

return false;
}
return !value;
Expand Down
Loading