[Rgen] Add extra data about the return type of a method. #21901

mandel-macaque · 2025-01-06T00:35:40Z

Later this information will be used to make decisions when emitting code.

mandel-macaque · 2025-01-06T00:36:01Z

/azp run xamarin-macios-pr

azure-pipelines · 2025-01-06T00:36:20Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Copilot reviewed 5 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (11)

tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/MethodEqualityComparerTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/MethodReturnTypeComparerTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ClassCodeChangesTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/MethodComparerTests.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Generator/DataModel/MethodsEqualityComparer.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Generator/DataModel/Parameter.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Generator/DataModel/MethodComparer.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Generator/DataModel/Method.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Generator/Extensions/TypeSymbolExtensions.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/InterfaceCodeChangesTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/MethodTests.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnType.cs:48

Add a null or empty check for the type string to ensure robustness.

internal MethodReturnType (string type)

src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnType.cs:121

[nitpick] Improve the formatting of the ToString method by placing the closing brace '}' on a new line.

public override string ToString ()

src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnType.cs

github-actions · 2025-01-06T00:39:49Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Co-authored-by: Copilot <[email protected]>

mandel-macaque · 2025-01-06T03:33:21Z

/azp run xamarin-macios-pr

azure-pipelines · 2025-01-06T03:33:40Z

Azure Pipelines successfully started running 1 pipeline(s).

mcumming · 2025-01-06T13:54:57Z

src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnType.cs

@@ -0,0 +1,133 @@
+using System;


Needs copyright notice

See #21900 (review)

mcumming · 2025-01-06T13:55:34Z

src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnTypeComparer.cs

@@ -0,0 +1,32 @@
+using System;


Needs copyright notice

Same #21900 (review)

mandel-macaque · 2025-01-06T18:10:34Z

/azp run xamarin-macios-pr

azure-pipelines · 2025-01-06T18:10:52Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2025-01-06T19:07:37Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-06T19:19:03Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-06T19:33:17Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-06T19:34:55Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-06T19:34:57Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-06T19:35:35Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-06T19:44:59Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-06T21:46:55Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 113 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d8ad5c2544528b5fea115f233234d24badcea167 [PR build]

mandel-macaque · 2025-01-06T22:50:06Z

/azp run xamarin-macios-pr

azure-pipelines · 2025-01-06T22:50:27Z

Azure Pipelines successfully started running 1 pipeline(s).

github-actions · 2025-01-06T22:53:45Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

stephen-hawley · 2025-01-07T21:48:10Z

src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnType.cs

+namespace Microsoft.Macios.Generator.DataModel;
+
+/// <summary>
+/// Readonly structure that represents a change in a method return type.


I don't understand what is meant by "a change in"

[Rgen] Add extra data about the return type of a method.

e7fc201

Later this information will be used to make decisions when emitting code.

mandel-macaque requested a review from Copilot January 6, 2025 00:35

Copilot AI reviewed Jan 6, 2025

View reviewed changes

src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnType.cs Outdated Show resolved Hide resolved

Auto-format source code

b933156

Update src/rgen/Microsoft.Macios.Generator/DataModel/MethodReturnType.cs

7c04e28

Co-authored-by: Copilot <[email protected]>

This comment has been minimized.

Sign in to view

mcumming requested changes Jan 6, 2025

View reviewed changes

dalexsoto approved these changes Jan 6, 2025

View reviewed changes

Merge branch 'main' into dev/mandel/return-type-struct

d8ad5c2

This comment has been minimized.

Sign in to view

mandel-macaque added 2 commits January 6, 2025 17:44

Merge branch 'main' into dev/mandel/return-type-struct

c5e0612

Fix tests after merge with main.

7f98f4a

Auto-format source code

ca7c54d

mcumming approved these changes Jan 7, 2025

View reviewed changes

rolfbjarne approved these changes Jan 7, 2025

View reviewed changes

stephen-hawley reviewed Jan 7, 2025

View reviewed changes

stephen-hawley approved these changes Jan 7, 2025

View reviewed changes

haritha-mohan approved these changes Jan 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Rgen] Add extra data about the return type of a method. #21901

[Rgen] Add extra data about the return type of a method. #21901

mandel-macaque commented Jan 6, 2025

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

Copilot AI left a comment

github-actions bot commented Jan 6, 2025

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mcumming Jan 6, 2025

mandel-macaque Jan 6, 2025

mcumming Jan 6, 2025

mandel-macaque Jan 6, 2025

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 6, 2025

vs-mobiletools-engineering-service2 commented Jan 6, 2025

vs-mobiletools-engineering-service2 commented Jan 6, 2025

vs-mobiletools-engineering-service2 commented Jan 6, 2025

vs-mobiletools-engineering-service2 commented Jan 6, 2025

vs-mobiletools-engineering-service2 commented Jan 6, 2025

vs-mobiletools-engineering-service2 commented Jan 6, 2025

vs-mobiletools-engineering-service2 commented Jan 6, 2025

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

stephen-hawley Jan 7, 2025

[Rgen] Add extra data about the return type of a method. #21901

Are you sure you want to change the base?

[Rgen] Add extra data about the return type of a method. #21901

Conversation

mandel-macaque commented Jan 6, 2025

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2025

⚠️ Your code has been reformatted. ⚠️

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mcumming Jan 6, 2025

Choose a reason for hiding this comment

mandel-macaque Jan 6, 2025

Choose a reason for hiding this comment

mcumming Jan 6, 2025

Choose a reason for hiding this comment

mandel-macaque Jan 6, 2025

Choose a reason for hiding this comment

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 6, 2025

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Jan 6, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Jan 6, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jan 6, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 6, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 6, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Jan 6, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 6, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts

mandel-macaque commented Jan 6, 2025

azure-pipelines bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

⚠️ Your code has been reformatted. ⚠️

stephen-hawley Jan 7, 2025

Choose a reason for hiding this comment