Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: Add misc dependencies for additional functionality #37794

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

systemd: Add misc dependencies for additional functionality #37794

wants to merge 2 commits into from

Conversation

justinvreeland
Copy link
Member

Also runs the upstream tests with some skips that don't work primarily due to the runtime env and explicitly build for release.

Also add tpm2-tss to build the systemd related pieces.

@octo-sts octo-sts bot added the bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. label Dec 19, 2024
@justinvreeland
Copy link
Member Author 

❌ aarch64/systemd-test-257.1-r0.apk

usr/lib/systemd/tests/testdata/units/TEST-07-PID1.main-PID-change.sh (CRITICAL)

References

Seems reasonable to flag. I can drop the package or that particular file if need be but it's nice to have the tests.

@justinvreeland justinvreeland marked this pull request as ready for review December 19, 2024 23:12
@egibs egibs added the malcontent/reviewed The malcontent findings in this PR have been manually reviewed by security. label Dec 20, 2024
@justinvreeland justinvreeland force-pushed the jvreeland/misc-systemd-updates branch 2 times, most recently from 31c9937 to 1c3a144 Compare January 2, 2025 23:03
@justinvreeland justinvreeland mentioned this pull request Jan 2, 2025
Open
@justinvreeland justinvreeland force-pushed the jvreeland/misc-systemd-updates branch from 1c3a144 to 23b4c52 Compare January 6, 2025 16:21
89luca89
89luca89 requested changes Jan 7, 2025
View reviewed changes
systemd.yaml Show resolved Hide resolved
Justin Vreeland added 2 commits January 8, 2025 11:10
tpm2-tss: new package used as systemd dep for tpm access
5251134
systemd: Add misc dependencies for additional functionality
ce6d619 
Also runs the upstream tests with some skips that don't work primarily
due to the runtime env and explicitly build for release.
@justinvreeland justinvreeland force-pushed the jvreeland/misc-systemd-updates branch from 23b4c52 to ce6d619 Compare January 8, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnox xnox Awaiting requested review from xnox

@89luca89 89luca89 Awaiting requested review from 89luca89

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. malcontent/reviewed The malcontent findings in this PR have been manually reviewed by security.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinvreeland @89luca89 @egibs