-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warnings if multiple JSX renderers are used #12887
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8dc2140 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered having this logic in core? The integrations shouldn't be aware of each other, instead the core needs to know
I think the issue is core doesn't have access to the integrations options so it can't check include/exclude |
@florian-lefebvre is correct. Core would've been the better solution but it can't see what options are passed |
I don't see any issue at all. We could expose a utility from |
@ematipico Is that just for the known renderers so that the integration can throw the warning? I'd be happy to implement it there |
Changes
include
orexclude
options when using multiple UI frameworks together.Testing
As this is just a warning printed to console, no tests have been added.
Docs
As this is just a warning printed to console, no docs have been added.