Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change uncomments a line used to detect the monorepo root for Rush projects. This change is necessary to include the node modules + correct symlinks as part of the Vercel build.
In a Rush monorepo with the following structure:
Running the build process in our
apps/www
folder results in the following structure:Which resolves in incorrect symlinks, as well as no
node_modules
sources copied in to the.vercel
folder.If deployed to Vercel, it results in the following error:
After the fix, the project structure uses the monorepo root:
Testing
Testing was done manually on a Vercel account. I highly doubt before this users were able to run Astro on their monorepos.
Docs
Nothing of note