T381334: Translations #5124
Merged
T381334: Translations #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-olson1214
requested review from
a team and
mazevedofs
and removed request for
a team
l-olson1214
force-pushed
the
T381330-v2-ins
branch
from
66c95ec to
05e2164
Compare
added 2 commits
January 7, 2025 10:31
# Conflicts: # Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
mazevedofs
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Mostly some details on the strings, but in Spanish, Italian, and German I'm seeing the englishHoursReadingSlide, the englishTopReadSlide, and the englishEditsSlide in English instead of Spanish. In French, it was all translated (I didn't check the copy to see if it was updated though)
mazevedofs
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Just two occurrences of the xxx left, and since we'll be adding translations for the slides that contain En-only info in https://phabricator.wikimedia.org/T382914 we can move forward with this PR
l-olson1214
force-pushed
the
T381330-v2-ins
branch
from
2474715 to
6bbbdfb
Compare
# Conflicts: # Wikipedia/Localizations/en.lproj/Localizable.strings # Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
mazevedofs
requested changes
Jan 8, 2025
| "year-in-review-share-text" = "這是我的 Wikipedia 年度回顧，由 Wikipedia iOS 應用程式製作。 (https://apps.apple.com/app/wikipedia/id324715238) #WikipediaYearInReview"; | ||
| "year-in-review-feature-explore-body" = "Wikipedia 是世界歷史上規模最大的知識資源，且免費提供給世界各地的每一個人。透過 Wikipedia 的視角，回顧 2024 年的點點滴滴。"; | ||
| "year-in-review-base-saved-title" = "我們擁有超過 $1 萬個閱讀清單"; | ||
| "year-in-review-base-saved-subtitle" = "今年，活躍的 iOS 應用程式用戶創建了超過 %1 萬個閱讀清單。將文章增加到閱讀清單，可以讓您即使在離線時也能存取文章。此外，您還可以登入帳戶，將閱讀清單同步到不同裝置。"; |
There was a problem hiding this comment.
I think it should be $1 instead of %1
l-olson1214
force-pushed
the
T381330-v2-ins
branch
from
a578123 to
0552983
Compare
mazevedofs
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T381334
https://phabricator.wikimedia.org/T382914
Notes
Test Steps
Screenshots/Videos