Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Response's statusText check #1795

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Correct Response's statusText check #1795

merged 1 commit into from
Dec 12, 2024

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 12, 2024

This has been wrong for a decade (see 3864756) and nobody noticed until now.

Fixes #1794.


Omitting template as this has been implemented "correctly" for a decade as well.


Preview | Diff

This has been wrong for a decade (see 3864756) and nobody noticed until now.

Fixes #1794.
@F3n67u
Copy link

F3n67u commented Dec 12, 2024

Looks good to me, thank you for the fix!

@annevk annevk merged commit 276aac1 into main Dec 12, 2024
2 checks passed
@annevk annevk deleted the statustext branch December 12, 2024 17:08
F3n67u added a commit to F3n67u/ladybird that referenced this pull request Dec 14, 2024
Synced change from whatwg/fetch#1795.

No functional changes; only update comments to reflect the latest
spec.
F3n67u added a commit to F3n67u/ladybird that referenced this pull request Dec 14, 2024
Synced change from whatwg/fetch#1795.

No functional changes; only update comments to reflect the latest
spec.
F3n67u added a commit to F3n67u/ladybird that referenced this pull request Dec 14, 2024
Synced change from whatwg/fetch#1795.

No functional changes; only update comments to reflect the latest
spec.
F3n67u added a commit to F3n67u/ladybird that referenced this pull request Dec 14, 2024
Synced change from whatwg/fetch#1795.

No functional changes; only update comments to reflect the latest
spec.
AtkinsSJ pushed a commit to LadybirdBrowser/ladybird that referenced this pull request Dec 15, 2024
Synced change from whatwg/fetch#1795.

No functional changes; only update comments to reflect the latest
spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Empty statusText does not match the reason-phrase token production
2 participants