Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reporter): skipped tests to have "skipped" state #7165

Conversation

AriPerkkio
Copy link
Member

Description

const result = this.task.result
if (!result || result.state === 'run' || result.state === 'queued') {
return {
state: 'pending',
errors: undefined,
}
}

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio requested a review from sheremet-va January 3, 2025 12:54
@sheremet-va
Copy link
Member

#7067

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 639032d
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6777ddeee72e3e00087041ec
😎 Deploy Preview https://deploy-preview-7165--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio
Copy link
Member Author

#7067

Had completely forgotten that! Weird how similar solution I ended up with in this PR 😄

@AriPerkkio AriPerkkio closed this Jan 3, 2025
@AriPerkkio AriPerkkio deleted the fix/reported-entity-skipped-result branch January 3, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants