Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow getMockImplementation to return "once" implementation #7033

Merged

Conversation

chaptergy
Copy link
Contributor

@chaptergy chaptergy commented Dec 5, 2024

Description

Adds a method to get the mock implementation including implementations, which are temporary and created with mock...Once.
Fixes #7030.

A new method was added in order to remain backwards compatible. If this is not desired, it can be replaced.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8cf9559
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6751cd3b3bc9880008dd5194
😎 Deploy Preview https://deploy-preview-7033--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6979eb3
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/677bd1ff8107ed00086bb44f
😎 Deploy Preview https://deploy-preview-7033--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member

sheremet-va commented Dec 5, 2024

We don't need a new method for this. The old one should return the current implementation

@chaptergy
Copy link
Contributor Author

@sheremet-va Sorry for the delay. I have removed the getNextMockImplementation() and have instead overwritten the getMockImplementation() logic.

@chaptergy chaptergy force-pushed the feature/get-next-mock-implementation branch from 439e280 to 6979eb3 Compare January 6, 2025 12:52
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hi-ogawa hi-ogawa changed the title Adds getNextMockImplementation fix: allow getMockImplementation to return "once" implementation Jan 7, 2025
@sheremet-va sheremet-va merged commit 3912554 into vitest-dev:main Jan 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getMockImplementation only returns permanent implementation, not onceImplementation
3 participants