Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react-router test #348

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

markdalgleish
Copy link
Contributor

Added a test for React Router. I've successfully run this test locally so I've also added it to the workflows.

Thanks as always for all of your hard work on the project 🙏

@dominikg
Copy link
Collaborator

dominikg commented Jan 3, 2025

how does this relate to remix? should it replace that or is it a different testsuite that adds extra coverage for vite?

@markdalgleish
Copy link
Contributor Author

React Router v7 now has an official Vite plugin which supersedes Remix.

The Remix test could potentially be removed, but it might be a good idea to keep it for a while to ensure everything is working while the community migrates across.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dominikg lets have the two for now. @markdalgleish, it would be good to remove the remix one soon though. I would consider this not that far from a major from any other framework and in that case, even if most users are initially in the prev version, we aren't testing them and only checking the latest were the main development is carried out. If you think that we should keep both remix and react router for more than a few weeks, I think we should discuss why that's the case.

@patak-dev patak-dev merged commit 9352768 into vitejs:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants