-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): execute with node22 #347
base: main
Are you sure you want to change the base?
Conversation
additional failing suites
|
hmm, why would switching to node22 make vike or analog fail? |
I think this is a flakey test on the Analog side and not specifically tied to node22. See if a re-run fixes it for your CI |
It was already fixed last week. (In case you're curious: it was just some new Node.js warning that Vike's CI didn't whitelist yet.) Let me know if Vike still fails and I'll have another look at it. |
triggered a rerun, looks like vike and analog passed, and the fails are similar to the last scheduled run, so this should be good to go. The change to deno@2 can be in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocked by error caused by vmthreads use in analog testsuite, see https://discord.com/channels/804011606160703521/1324320073460088894
same with #262 but for node 22