ECR Region configuration variable #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fampton
approved these changes
Sep 10, 2018
BrianBland
reviewed
Sep 11, 2018
app/vili.go
Outdated
| @@ -159,7 +159,7 @@ func New() *App { | |||
| registryID = &ecrAccountID | |||
| } | |||
| err := repository.InitECR(&repository.ECRConfig{ | |||
| Region: config.GetString(config.AWSRegion), | |||
| Region: config.GetString(config.ECRRegion), | |||
There was a problem hiding this comment.
Should this fall back to AWSRegion if blank?
There was a problem hiding this comment.
Great point!
I usually think that explicit configuration is best, so I made the ecr-region a required configuration variable. Let me know what you think..... if this doesn't make sense, happy to change this to fall back to using the aws-region instead.
There was a problem hiding this comment.
After an end of the day conversation with @BrianBland yesterday, we decided to change the logic to default to using the aws-region variable if ecr-region is not set.
I've added logic to make this so.
nikhildhamija24
approved these changes
Sep 11, 2018
brianwallace
force-pushed
the
ecr-region
branch
from
beb8c3f to
cbc596f
Compare
Default to using the aws-region variable of the ecr-region is not explicityly set.
brianwallace
force-pushed
the
ecr-region
branch
from
cbc596f to
1cbbcc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration variable called
ecr-region. It allows you to run vili in one region, but configure vili to connect to an ECR repo in a different AWS region.