APP-6997: Implement CreateOAuthApp CLI #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
gloriacai01
commented
Jan 7, 2025
cli/client.go
Outdated
| enabledGrants := args.EnabledGrants | ||
|
|
||
| clientAuthentication, err := clientAuthToProto(args.ClientAuthentication) | ||
| func createOauthAppConfig(clientAuthentication, pkce, urlValidation, logoutURI string, |
There was a problem hiding this comment.
factored this into a separate function since updateOauthApp and createOauthApp both need to create an oauthAppConfig
maxhorowitz
reviewed
Jan 7, 2025
cli/client.go
Outdated
| enabledGrants := args.EnabledGrants | ||
|
|
||
| clientAuthentication, err := clientAuthToProto(args.ClientAuthentication) | ||
| func createOauthAppConfig(clientAuthentication, pkce, urlValidation, logoutURI string, |
There was a problem hiding this comment.
The term "create" almost feels overloaded here because we're using it as part of both the create/update OAuth app flows - maybe something a little more distinct so it's not confused with OAuth app creation ?
cli/client.go
Outdated
| return err | ||
| } | ||
|
|
||
| printf(cCtx.App.Writer, "Successfully created OAuth app %s", args.ClientName) |
There was a problem hiding this comment.
I want us to display the client ID and client secret that are returned in the response type.
| flags[oauthAppFlagClientAuthentication] = "required" | ||
| flags[oauthAppFlagURLValidation] = "allow_wildcards" | ||
| flags[oauthAppFlagPKCE] = "not_required" | ||
| flags[oauthAppFlagOriginURIs] = []string{"https://woof.com/login", "https://arf.com/"} |
stuqdog
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
I'll let @maxhorowitz speak to some of the more implementation-y details, but from a CLI perspective this lgtm!
viambot
added
safe to test
viambot
added
safe to test
maxhorowitz
approved these changes
Jan 8, 2025
Co-authored-by: Max Horowitz <[email protected]>
Co-authored-by: Max Horowitz <[email protected]>
viambot
added
safe to test
Co-authored-by: Max Horowitz <[email protected]>
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add create oauth app command to the cli. usage text screenshot:
