-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-2949: QA board examples #4661
base: main
Are you sure you want to change the base?
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
// myBoard, err := board.FromRobot(robot, "my_board") | ||
// | ||
// // Get the names of all known analog pins | ||
// names := myBoard.AnalogNames() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think AnalogNames is supported anymore
@@ -27,7 +27,7 @@ import ( | |||
// pin, err := myBoard.GPIOPinByName("15") | |||
// | |||
// // Get if it is true or false that the state of the pin is high. | |||
// high := pin.Get(context.Background(), nil) | |||
// high, err := pin.Get(context.Background(), nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the returns of pin.Get
change? like why is there an error now?
@@ -37,7 +37,7 @@ import ( | |||
// pin, err := myBoard.GPIOPinByName("15") | |||
// | |||
// // Returns the duty cycle. | |||
// duty_cycle := pin.PWM(context.Background(), nil) | |||
// duty_cycle, err := pin.PWM(context.Background(), nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment here
@@ -67,7 +67,7 @@ import ( | |||
// pin, err := myBoard.GPIOPinByName("15") | |||
// | |||
// // Set the PWM frequency of this pin to 1600 Hz. | |||
// high := pin.SetPWMFreq(context.Background(), 1600, nil) | |||
// err = pin.SetPWMFreq(context.Background(), 1600, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also did not know that this changed
No description provided.