[APP-7004] Implement ListOAuthApplications CLI Command #4646
+112
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
viambot
added
the
safe to test
JosephBorodach
force-pushed
the
APP-7004-Implement-ListOAuthApplications-CLI-Command
branch
from
7147156 to
9c9948f
Compare
viambot
added
safe to test
stuqdog
approved these changes
Dec 19, 2024
JosephBorodach
force-pushed
the
APP-7004-Implement-ListOAuthApplications-CLI-Command
branch
from
9c9948f to
1af5323
Compare
viambot
added
safe to test
JosephBorodach
force-pushed
the
APP-7004-Implement-ListOAuthApplications-CLI-Command
branch
from
1af5323 to
8e62805
Compare
viambot
added
safe to test
JosephBorodach
force-pushed
the
APP-7004-Implement-ListOAuthApplications-CLI-Command
branch
from
8e62805 to
4dc0a89
Compare
viambot
added
safe to test
jr22
reviewed
Dec 20, 2024
cli/app.go
Outdated
| @@ -465,6 +465,18 @@ var app = &cli.App{ | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| Name: "list-oauth-apps", | |||
There was a problem hiding this comment.
do we want this to be the command? or should it be something like organization oauth list so we can also have organization oauth create etc.
would check scope and check with @maxhorowitz
There was a problem hiding this comment.
I used the existing delete command (created by gloria) as an example to work of so it should be good now
jr22
reviewed
Dec 20, 2024
cli/client.go
Outdated
| OrgID string | ||
| } | ||
|
|
||
| // ListOAuthAppsAction corresponds to `list-oauth-apps`. |
There was a problem hiding this comment.
can you add tests in client_test too pls?
…ListOAuthApplications-CLI-Command
viambot
added
safe to test
viambot
added
safe to test
viambot
removed
the
safe to test
viambot
added
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See ticket here
Org with an auth app
Command
Output
Org without an auth app
Command
Output