Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(isMobilePhone): updated locale typing to better reflect ValidatorJS functionality #2492

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kurbar
Copy link

@kurbar kurbar commented Jun 18, 2024

Description

Updated typings for IsMobilePhone decorator usage to better reflect of the actual functionality of ValidatorJS's validation.

Notable changes:

  • support setting locale as "any" to validate against any locale.
  • allow locale to be an array of locales to validate against multiple locales.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feature: Allow IsMobilePhone Decorator to Accept Multiple Locales
1 participant