Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tpl to configmaps #283

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lozbrown
Copy link

@lozbrown lozbrown commented Jan 6, 2025

Add TPL to all functions to support allowing environment specifics to in seperate values files.

as suggested on slack by @nineinchnick

@cla-bot cla-bot bot added the cla-signed label Jan 6, 2025
@nineinchnick
Copy link
Member

I'm reluctant to adding tpl everywhere without explicit use cases, because there might be unexpected side effects and we won't be able to remove this without breaking backward compatibility.

We should add tests showcasing the usage for every place we're adding tpl calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants