Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): clarify repeated XML tags vs. comma-separated in GUI #890

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

acolomb
Copy link
Member

@acolomb acolomb commented Jan 6, 2025

Add similar text to all repeatable configuration options, mentioning
the difference between comma-separated lists in the GUI vs. repeating
the tag (without plural "s") in the XML file. Loosely based on the
existing sentence for <listenAddress>.

Add similar text to all repeatable configuration options, mentioning
the difference between comma-separated lists in the GUI vs. repeating
the tag (without plural "s") in the XML file.  Loosely based on the
existing sentence for <listenAddress>.
@acolomb
Copy link
Member Author

acolomb commented Jan 6, 2025

This is a replacement for the suggested change #832.

Copy link
Member

@calmh calmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolomb acolomb merged commit f3165de into syncthing:main Jan 7, 2025
3 checks passed
@acolomb acolomb deleted the clarify-repeated-config-tags branch January 7, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants