Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container-ize SiteDefaults #298

Conversation

ryanmitchell
Copy link
Contributor

As discussed on Discord this PR container-izes SiteDefaults, allowing developers to override its methods, eg

            $this->app->bind(\Statamic\SeoPro\SiteDefaults::class, \App\MySiteDefaults::class);

My use case is storing the data in a database rather than a flat file by overloading the save and getDefaults methods.

@jesseleite
Copy link
Member

Closed in favour of a slightly simpler implementation in #302. Thanks as always for the rad PRs! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants