Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindException declared but not handled by ExceptionHandler #34214

Closed

Conversation

remeio
Copy link
Contributor

@remeio remeio commented Jan 8, 2025

The method doesn't handle the BindException anymore.

Close gh-33952.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 8, 2025
@bclozel bclozel self-assigned this Jan 8, 2025
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 8, 2025
@bclozel bclozel changed the title Remove the BindException from the annotation. BindException declared but not handled by ExceptionHandler Jan 8, 2025
@bclozel
Copy link
Member

bclozel commented Jan 8, 2025

@remeio We're in the process of changing our contribution process. A required check is not performed right now but will be soon.
Could you amend your commit to sign it off? See https://spring.io/blog/2025/01/06/hello-dco-goodbye-cla-simplifying-contributions-to-spring

In your case, you verify that your contribution checks the DCO and then do the following:

git amend -s
git push --force

Thanks!

@bclozel bclozel added this to the 6.2.2 milestone Jan 8, 2025
@remeio remeio force-pushed the remove_BindException_handle branch from 56da53d to 8a37faf Compare January 8, 2025 15:18
@remeio
Copy link
Contributor Author

remeio commented Jan 8, 2025

@bclozel Hi,I had changed my commit message using the DCO.

@bclozel bclozel closed this in 53b3b93 Jan 8, 2025
@bclozel
Copy link
Member

bclozel commented Jan 8, 2025

Thanks for your contribution @remeio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BindException not handled anymore but still registered in ExceptionHandler
3 participants