Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization by caching the map of cache key and shouldSkip #34207

Closed
wants to merge 2 commits into from

Conversation

remeio
Copy link
Contributor

@remeio remeio commented Jan 7, 2025

I add the cache for method AspectJAwareAdvisorAutoProxyCreator#shouldSkip:

  • the key of cache: the cache key for the given class and name
  • the value of cache: Boolean value of should skip

And resolve TODO: Consider optimization by caching the list of the aspect names.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 7, 2025
@bclozel
Copy link
Member

bclozel commented Jan 8, 2025

Thanks for the proposal, but this "TODO" is 17+ years old and this particular point never showed in performance benchmarks. I'll remove this mention on the main branch.

@bclozel bclozel closed this Jan 8, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants