-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch out winapi to windows-rs #298
base: main
Are you sure you want to change the base?
Changes from all commits
221553e
141cb2b
8cccb02
9535246
f8798d3
37e446d
6531cde
8e0319d
6066bc6
334a990
d686fbd
e286414
702b317
8b3a0c9
87ed642
7b4b569
5449d93
f241f89
d1f658f
3e710fe
1b15acb
c8d139c
65a0348
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,13 +14,11 @@ use crate::Error; | |
use crate::GLApi; | ||
|
||
use euclid::default::Size2D; | ||
use windows::Win32::Graphics::Direct3D::{D3D_DRIVER_TYPE_UNKNOWN, D3D_DRIVER_TYPE_WARP}; | ||
|
||
use std::os::raw::c_void; | ||
|
||
use winapi::shared::minwindef::UINT; | ||
use winapi::um::d3dcommon::{D3D_DRIVER_TYPE_UNKNOWN, D3D_DRIVER_TYPE_WARP}; | ||
|
||
const INTEL_PCI_ID: UINT = 0x8086; | ||
const INTEL_PCI_ID: u32 = 0x8086; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I saw many number types use rust types directly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's pretty okay to use Rust types directly because |
||
|
||
/// A no-op connection. | ||
/// | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use windows-sys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, windows-sys does not have the feature set for manipulating DXGI so at best we would be using a mixture of both windows and windows-sys