Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not found error for attestation build summary URL #5365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kachick
Copy link

@kachick kachick commented Dec 26, 2024

image

image

image

When I used the https://github.com/rubygems/release-gem action with .github/workflows/release.yml, it displays the Build summary.

However it links to https://github.com/OWNER/REPO/actions/runs/.github/workflows/release.yml and displays Not Found error.
As far as I know, GitHub provides a list of workflow runs as https://github.com/OWNER/REPO/actions/workflows/release.yml.
Is this just a typo? Or github provides the runs link with several patterns?


@segiddins ref: #5330

I'm posting this PR instead of creating an issue, for sharing the related code. I'm okay for this closed anytime. 🙇‍♂️

@segiddins
Copy link
Member

Thanks, I will figure this out when I get back to work next week

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (96cba03) to head (90c5750).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5365      +/-   ##
==========================================
- Coverage   97.14%   94.37%   -2.77%     
==========================================
  Files         458      458              
  Lines        9584     9643      +59     
==========================================
- Hits         9310     9101     -209     
- Misses        274      542     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kachick kachick force-pushed the fix-attestation-wrong-url branch from 969b4b6 to 90c5750 Compare December 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants