Gitignore Basic Setup #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
requested changes
Jan 5, 2025
| uv.lock | ||
|
|
||
| # poetry | ||
| poetry.lock |
There was a problem hiding this comment.
We shouldn't gitignore lock files — robot code is application code, not library/package code.
| @@ -30,7 +30,7 @@ def run(self, main_file: pathlib.Path, project_path: pathlib.Path): | |||
|
|
|||
| logger.info("Created empty %s", main_file) | |||
|
|
|||
| # Create pyproject.toml if it doesn't already exist | |||
| # Create pyproject.toml and .gitignore if it doesn't already exist | |||
There was a problem hiding this comment.
As written, this will always write a .gitignore (overwriting one if it does exist), iff a pyproject.toml doesn't exist. This doesn't match the comment, and I think the comment is closer to the intent.
| # Windows shortcuts | ||
| *.lnk | ||
|
|
||
| ### Gradle ### |
There was a problem hiding this comment.
A significant chunk of these contents are C++/Java specific. There's no reason to include them for a Python project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a possible solution that resolves:
robotpy init should set up a basic .gitignore #107