Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Animate history entries #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Animate history entries #22

wants to merge 2 commits into from

Conversation

roman01la
Copy link
Member

@roman01la roman01la commented Jan 20, 2019

Resolves #18

@mfikes
Copy link
Member

mfikes commented Jan 20, 2019

That's cool! It is difficult to see from the animation above, but if you try this on an iOS device, the form entered animates in slightly before the evaluation result, which gives a pleasing cause / effect feeling. I can't recall if I coded anything to do this, other than perhaps animating the input, evaluating and then animating the output. I tried looking in the iOS code and didn't see any evidence of specifically delaying the output relative to the input. (It looks like they both animate in over a period of 50 ms).

@mfikes
Copy link
Member

mfikes commented Jan 20, 2019

Oh, wait. Looking again, even though the animation duration is 50 ms, there is indeed a delay between the form entry and the evaluation of another 50 ms here https://github.com/replete-repl/replete-ios/blob/b08f543e3f504d7ca79a004d906e67fad416474c/Replete/ReplViewController.swift#L461

@roman01la
Copy link
Member Author

Yeah, I'm looking into ways of doing this on Android. 50ms delay before evaluating a form seems legit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants