Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data dict 2024 & some scripts #18

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

biancarosa
Copy link
Contributor

No description provided.

@biancarosa biancarosa force-pushed the dados-2024 branch 2 times, most recently from 0ac054a to 7232044 Compare October 20, 2024 16:24
Copy link
Contributor

@naanadr naanadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ainda não olhei o código todo, mas faltou adicionar no README do projeto referência ao ano 2024 e ao script que tu fez.

dados/python-brasil-2024/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menciona esse README e diretório no README do repositório.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adiciona o ano de 2024 no README do projeto

Comment on lines +3 to +4
## Normalize os nomes de colunas
```python data-cleaner.py normalize-columns-cmd ../dados/python-brasil-2024/inscricoes-participantes-original.csv ../dados/python-brasil-2024/inscricoes-participantes.csv```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adiciona uma explicação mais detalhada sobre esse script, e como que faz para gerar o csv original.

@@ -0,0 +1,13 @@
# Usage

## Normalize os nomes de colunas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Normalize os nomes de colunas
## Normaliza o nome das colunas


E use o output para como base para o dicionario de dados ;)

## Columns remover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Columns remover
## Remove colunas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Porque a pessoa vai querer remover colunas? Adiciona mais detalhes sobre isso nessa docs.

## Columns remover
```python data-cleaner.py remove-columns-cmd ../dados/python-brasil-2024/inscricoes-participantes.csv ../dados/python-brasil-2024/inscricoes-participantes.csv```

## Replace separator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Replace separator
## Altera separador do CSV


## Replace separator

```python data-cleaner.py replace-separator-cmd ../dados/python-brasil-2024/inscricoes-participantes.csv ../dados/python-brasil-2024/inscricoes-participantes.csv```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mesma sugestão que dei nos outros comentários relacionados a esse script.

Comment on lines +74 to +77
df = remove_columns(df, columns)


# Write the modified DataFrame to a new CSV file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
df = remove_columns(df, columns)
# Write the modified DataFrame to a new CSV file
df = remove_columns(df, columns)
# Write the modified DataFrame to a new CSV file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qual o Python qu tu utilizou? Coloca ele aqui tbm na pastinha por favor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants