Fix #18423 - reveal_type not run in "unreachable" branches #18424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18423 -
reveal_type
not run in "unreachable" branchesCurrently,
reveal_type
does not output type information in unreachable code branches, such as those followingassert_never
. This is becausemypy
considers such code unreachable and skips type-checking it. However, for debugging purposes, it is useful to see the type information even in unreachable branches.Solution
This PR modifies the
reveal_type
function to explicitly handle unreachable code by checking forUninhabitedType
, whichmypy
uses to represent unreachable branches. WhenUninhabitedType
is encountered,reveal_type
outputs"Never"
.Changes
reveal_type
Function:UninhabitedType
to handle unreachable code.UninhabitedType
, the function outputs"Never"
.TypeStrVisitor
to print the type.Why This Fix Works
UninhabitedType
Represents Unreachable Code:mypy
usesUninhabitedType
to represent unreachable code, such as afterassert_never
. By checking forUninhabitedType
, we can detect and handle this case.mypy
type system. It leverages the existingUninhabitedType
to represent the "never" case.